V0.5 Post Mortem
The major issues identified were:
- Matrix exposures was implemented in a hacky way and should of been rejected
- Clear definition of what step of preparation applied where is missing
- Preparation and normalization were mixed in the pcb_web node
- pcb_web is poorly named, incorrectly scoped, or violating its boundary with orchestrator
- The job preparation pipeline should have been defined earlier
- At what point a transition from http to ROS should be done is not defined
- pcb_calibration node is under scoped leading to other nodes taking responsibilities they should not
Remediations for V0.6:
- to To correct the issue with pcb_calibarion the followed actions are recommended
- Replace pcb_calibration with pcb_archive, increase the scope to tracking all on Pi files. To do this the following actions would take place:
- Remove the job repository from pcb_web
- Remove the preparations repository from pcb_web
- Remove the uploads repository from pcb_web
- Any access to the archive is not guaranteed to exist at a future time.
- Replace pcb_calibration with pcb_archive, increase the scope to tracking all on Pi files. To do this the following actions would take place:
- To correct the issues related to pcb_web the following actions are recommended:
- Remove all business logic from pcb_web
- Remove the via jig tool
- Move all rasterization to pcb_renderer
- This could involve making pcb_renderer a shared cpp & python package
- Rename pcb_web to pcb_bridge
- This is to reflect the reduction in scope.
- Remove all business logic from pcb_web
- To correct the issues related to process definitions:
- use Normalization -> Preparation -> Rasterization for preparing a exposure job.
- Normalization transforms the svg or gbr into a standard intermediate form.
- Preparation defines the transform to align the artwork with the top left corner.
- Rasterization transforms from the intermediate form to a final pixel out put. Only at this point is the calibrated work area enforced.
- Each step generates a build artifact that is tracked by pcb_archive.
- Preparation groups become tracked by archive, when a preparation is apart of a group artifact is updated by pcb_archive upon retrieval to match the latest group artifact.
- use Normalization -> Preparation -> Rasterization for preparing a exposure job.
- To correct the issue with exposure matrix:
- Introduce the concept of job groups. A job group is a sequence of jobs to complete
- A job group should be tracked as a artifact by pcb_archive
- pcb_orchestrator should accept a job group as a action
Notes for V0.6:
- Determining what the right scope for ROS node in this system is difficult. This application is not a perfect use case of ROS, at least at this stage. In future projects it should be considered to transition into ROS after more subsystems have been built up.
- Artwork refers both to art and pcb drawings.
- Artifact is any persistent information written to disk